As per the wiki picnic sites should be tagged tourism=picnic_site and not as amenity=picnic_site or leisure=picnic_site.
There are a small number tagged as amenity=picnic_site and leisure=picnic_site through out the world. I think these should all be tourism=picnic_site.
These are the number of picnic sites tagged as leisure=picnic_site
These are the number of picnice sites tagged as amenity=picnic_site ways
I’m looking into re-tagging the above into tourism=picnic_site in-order to have uniform tagging for picnic sites through out the world. The work-flow i’ll be following:
Re-tagging picnic sites with tourism=picnic_site tag https://github.com/mapbox/mapping/issues/147
For further details on the progress please refer to this repository.
Comment from escada on 22 December 2015 at 12:59
Please note that is considered a mechanical edit (you do not visit all those places in person).
Hence you have to follow the mechanical edit procedure: http://wiki.openstreetmap.org/wiki/Automated_Edits_code_of_conduct
o.a. you will have to consult the local communities to see whether they agree with the proposed change. Not everybody agrees with the content of the wiki. A blog post such as this is not considered the correct way to connect to the local communities
I’m pretty sure that e.g. the British community will oppose to any edit of this kind (at least a few vocal persons in that community)
You will also need a page such as http://wiki.openstreetmap.org/wiki/Automated_edits/Math1985/Musical_instrument, a dedicated account, etc.
This comment is not to prevent you from doing it, just informing you about the possible “dangers” along the way.
Comment from naoliv on 22 December 2015 at 13:01
“I’ll be going to each of the picnic sites and look for re-tagging it.” gives the impression that you will manually verify each one, while in https://github.com/mapbox/mapping/issues/147#issuecomment-166525158 we can see that “it will be a mechanized edit”.
It’s good to make it explicit that it will be an automatic process.
Also, whether possible, add mechanical=yes to the changeset.
Comment from RobJN on 22 December 2015 at 18:06
escada: Yes there can be a few vocal people in the British community however we have no formal group so it’s not clear what this means - he who shouts loudest…?
Personally I take a pragmatic view on each. In this case there are 5 ‘incorrectly’ tagged picnic sites in the UK spanning many years (5 years old, 3 years old, 3 years old, 4 months, 3 months). Trying to claim that these are anything more than a mistake would be difficult. As such I would be happy with the edit.
Comment from DaCor on 22 December 2015 at 19:06
Lets not over complicate where its not needed.
If they’re tagged wrong, they should be corrected.
Comment from Omnific on 23 December 2015 at 00:03
Not everything that has a process is a mechanical edit, escada. This kind of overreaction is very off-putting for people like OP who are doing needed manual tagging corrections.
Comment from jinalfoflia on 23 December 2015 at 08:06
Thank you everyone for the feedback.
@escada thank you for sharing the link to the code of conduct.
This correction falls into acceptable usage category. There is no need to have a wiki page for the this tag as the current wiki already states about the current tag tourism=picnic_site being the correct one.
I’ll be following the guidelines in the code of conduct and will be doing the following:
Create a single changeset for a country, so that if there is any need to revert anything it can be done easily.
Document all the changesets created while adding the tags, thus making it easy for anyone to look at them.
Will have a standard changeset comment Re-tagging picnic sites with tourism=picnic_site tag https://github.com/mapbox/mapping/issues/147
Comment from EdLoach on 23 December 2015 at 14:58
Surely it only falls into the acceptable usage category if “leisure” is an obvious typo for “tourism” based on the code of conduct you linked to?
Comment from DaCor on 23 December 2015 at 18:49
leisure=picnic_site - 100 items
tourism=picnic_site - 83,313 items
In other words, of 83,413 sites, 0.12% are tagged as leisure versus 99.88% tagged as tourism
I think its safe to conclude leisure is obviously incorrect
Comment from R0bst3r on 31 December 2015 at 11:22
Again we see how hard it can be to improve osm. Even just simple errors.
At least we see that it is possible … :)