OpenStreetMap logo OpenStreetMap

Changeset When Comment
119364430 over 3 years ago

Please use more descriptive changeset comments. osm.wiki/Good_changeset_comments

119277134 over 3 years ago

Thank you!

119277134 over 3 years ago

Deleting and re-drawing the buildings like this has removed information from the map, like the overhang in front of Back Bar, the extension to the side, the height and elevation of the building, and the history of the component nodes (osm.wiki/Good_practice#Keep_the_history ). A better way to do it might be to keep the building outline while you trace the parts, or to split it into segments and re-join them. JOSM (https://josm.openstreetmap.de/ ) also has plugins to make some of these operations easier (split area, replace geometry, revert tool).

118966057 over 3 years ago

This isn't a duplicate. The only other address point at 5540 Winfield has a unit number of 100, making it distinct. Additionally, the point you deleted had tags indicating that it was a vacant shop. The point should remain so that the next shop to move in can use the existing address point.

118570251 almost 4 years ago

Please use more detailed changeset comments. osm.wiki/Good_changeset_comments

118219572 almost 4 years ago

It's usually better to edit the building outline rather than delete and re-map, see osm.wiki/Good_practice#Keep_the_history . In this case you've also deleted the address of the building without adding it back.

118113586 almost 4 years ago

Thanks for contributing to OpenStreetMap! When deleting closed businesses, it's better to just remove the name and set shop=vacant, rather than delete the node entirely, if it has any other information on it like the location's address.

117967258 almost 4 years ago

OpenStreetMap maps what exists currently. If something is yet to be built or has recently been destroyed, use an appropriate lifecycle prefix: osm.wiki/Lifecycle_prefix or feature=construction osm.wiki/Comparison_of_life_cycle_concepts#.3Ckey.3E_.3D_.3Cstatus.3E_.2B_.3Cstatus.3E_.3D_.3Cvalue.3E
Here's my change changeset/117984726

117431999 almost 4 years ago

Hello. Please make sure to add a changeset comment describing the changes you made, especially for changes this large. osm.wiki/Good_changeset_comments

116321466 almost 4 years ago

You don't need to be a master, or have lots of spare time, to help contribute! For example, OSM South Bay has a list of our current projects here: https://github.com/codeforsanjose/OSM-SouthBay/blob/main/README.md#current-projects The MapRoulette projects only take a few minutes per task, and the SDP POI one has detailed instructions linked on the task page.

116350289 almost 4 years ago

I've also reverted this changeset in 117022304. If you can help it, try to improve building outlines instead of redrawing them totally. It's good practice to keep the history of objects as they improve: osm.wiki/Keep_the_history In this case, it also led to existing tags being removed: the building height, address, and elevation. You also shouldn't move buildings to align with aerial imagery. It's often the imagery that's actually offset, and there's a panel in the editor to let you adjust that. Finally, just because you can't find an editor preset for something doesn't mean it has to be tagged as something different. You can try searching the wiki, or asking for advice in the community communication channels.

116321466 almost 4 years ago

To fix this, I've reverted this change, and some of your other changes that did similar things, in changeset/117022116. I'm sorry. If it helps, here's a guide on modeling intersections that might be clearer than tagging reference: https://labs.mapbox.com/mapping/mapping-for-navigation/modeling-intersections-for-map-navigation/ Finally, I do encourage you to join either the Code for San Jose map nights (https://www.meetup.com/code-for-san-jose/) or the OpenStreetMap US Slack (https://slack.openstreetmap.us/), where you can ask questions or ask for feedback. We're always looking for new members!

116649782 almost 4 years ago

Thank you.

116321466 almost 4 years ago

Hello, and thanks for contributing to OpenStreetMap. I see that this changeset makes a number of problematic changes to the Almaden/Cherry intersection. See here for how divided highways should be mapped: osm.wiki/Editing_Standards_and_Conventions#Divided_highways In particular, multiple separate ways should only be used if there is a physical separation. Marked lanes can instead be mapped with various "lanes" keys: osm.wiki/Lanes Indeed, way/417059700 for example already has lanes information, making way/1022444949 redundant. Additionally, turn restriction relations 7680884, 7680885, and 7680886 are now broken, and some of the new ways cross existing ways without intersecting.

116649782 almost 4 years ago

The "practice" in OSM is ATYL, meaning no tags are inherently wrong. osm.wiki/Any_tags_you_like The page you linked says to use the tag "restriction", and the page on "lanes" describes how any tag can be combined with ":lanes", as was done here: osm.wiki/Lanes Finally, you have still not explained to me how any existing tags communicate that some lanes are no-right-on-red. You have removed information from the map with no adequate replacement.

116649782 almost 4 years ago

What OSM practices did the restriction violate? How does the "turn:lanes" tag indicate "no right turn on red"?

116623023 almost 4 years ago

This has been reverted in changeset/116628416.

116580696 almost 4 years ago

This new road runs over a number of other pedestrian ways without adding crossing nodes. Please resolve these errors in iD before uploading.

116403290 almost 4 years ago

I can still see the house in recent aerial imagery, so I've reverted this change in changeset/116437378.

116403290 almost 4 years ago

What is this? Why did you entirely delete the house? There is no private information here, only the shape and address of a house. See this page for what OSM considers private information: osm.wiki/Limitations_on_mapping_private_information and this page for what OSM considers appropriate to be mapped: osm.wiki/Good_practice#Verifiability