OpenStreetMap logo OpenStreetMap

Changeset When Comment
63478085 about 7 years ago

The old-style multipolygon dataset is part of the area fixing effort:

http://area.jochentopf.com/

While the task is marked as done, new old-style multipolygons are still created on a daily basis, and I still fix those.

As I'm fixing many issues, I'm not going to spend time digging for the reason an old-style multipolygon exists. If the fix is not obvious, I mark the relation as needing proper tags for a local mapper to fix, and move on to the next.

63478085 about 7 years ago

There are many more old-style multipolygons in the dataset I process each day, I cannot be bothered to use distrinct changeset comments for each.

Adding the fixme tag ensures that the relation doesn't show up in the old-style dataset, and that it shows up in other QA tools.

63216789 about 7 years ago

The old-style multipolygon (with only type=multipolygon tag) with the two members on the left (one outer and one inner) was removed, the correctly tagged multipolygon was updated to also include the inner from the other multipolygon, because it also includes its outer.

62159941 over 7 years ago

When I'm cleaning up QA issues, I'm not in mapping-mode, and won't spend time mapping new features.

Unused relations clutter the database, and add noise to an area where mappers should be able to focus on the features that are being used.

62159941 over 7 years ago

Leaving untagged ways not part of any relations also makes no sense.

You don't have to upload unfinished work, you can save the layer and continue later (with or without first updating all elements to sync possible work from other mappers).

62159941 over 7 years ago

There was no indication that you were working on the relation or its ways. It looked and smelled like a broken old-style multipolygon, hence was removed.

If you want work in progress retrained, you need to tag the elements appropriately.

62058282 over 7 years ago

Relations with only type=multipolygon are included in the old-style.osm.pbf dataset I use to fix these issues.

I added landuse=farmland because that what it looks like. Go and improve the tagging as your see fit.

60855304 over 7 years ago

Then please correct the tagging of the relation and its ways.

I just updated the old-style multipolygons.

That water tags came from relation/8457734 which has this way as only (outer) member.

Removing the tags should be sufficient.

Why are you shouting in this changeset instead of removing the erroneous tags?

47592706 over 7 years ago

Probably, yes.

47592706 over 7 years ago

The tags for those nodes can be deleted, they are just metadata from a GPS.

57731214 over 7 years ago

JOSM is much more suitable for editing relations.

It has the nice you can easily create multipolygons by selection the outer and inner ways and using the 'Create multipolygon' function, or use the 'Update multipolygon' feature to move the appropriate tags from the outer way to the existing relation.

https://josm.openstreetmap.de/wiki/Help/Action/CreateMultipolygon

57731214 over 7 years ago

The wiki has the reference documentation for multipolygon relations:

osm.wiki/Relation:multipolygon

The tags describing the feature need to be on the relation instead of on the outer way.

53660528 over 7 years ago

The wiki documents multipolygon relations. Since it's a wiki it can be made to say anything you want. :-)

I'll point you to this instead: http://area.jochentopf.com/old-style-josm.html

You can keep arguing here against the deletion of relations with only type=multipolygon tags, but that won't convince any one. Tag the relations appropriately, as documented in the Multipolygon wiki for example, and the relations won't even show up in the old-style multipolygon dataset. Or if you cannot tag it like a proper multipolygon, at least document your intentions with the relation in a fixme or note tag.

I've been fixing old-style multipolygons in a variety of ways on a daily basis for over a year now, if you keep creating invalid multipolygon relations like these I will step on your toes again. If you don't want that, learn for this discussion and tag the relations appropriately.

53660528 over 7 years ago

osm.wiki/Multipolygon

53660528 over 7 years ago

As long as the tags are on the ways and not on the relation it's not a proper multipolygon.

Using a relation to group ways is okay, but using type=multipolygon for the relation is not.

Adding fixme=<some reason> to the relation will keep it out of the data set I use to fix old-style multipolygons. You should take note of that if you don't want improper multipolygon relations touched.

53660528 over 7 years ago

It is when the tags are better left on the ways, the relation has no added value.

If you don't want multipolygon relations to be touched, you need to ensure they have proper tags along with the type=multipolygon.

In this case using a different type than multipolygon is probably more appropriate even.

53660528 over 7 years ago

Then tag the multipolygons appropriately so they are not considered old-style multipolygons (with only the type=multipolygon tag on the relation).

47663113 almost 8 years ago

In short: don't put tags on the outer way and have only type=multipolygon on the relation, move the tags from the outer way to the relation.

For further reading: osm.wiki/Relation:multipolygon

56891344 almost 8 years ago

Yes, see version 1 of relation/8076915.

56891344 almost 8 years ago

That's what it looks like on the imagery.

You're free to improve the tagging.

I'm just fixing old-style multipolygons with no tags on the relation.