OpenStreetMap
alefteris's Comments
| Changeset | When | Comment |
|---|---|---|
| 148766557 | almost 2 years ago | Hi there. Thanks for your edits and the addition of the service roads inside the port. I'd like to discuss the following deletions/changes: a) The POI node/9671880818 with amenity=coast_guard was deleted and instead the amenity=police was added in the building. Why is this change needed? There is already a used tag for coast guard (amenity=coast_guard). It has a proposed status, but it's used in other coast guard POIs in Greece and abroad and it's more appropriate for this POI kind. If the change was done, because the amenity=coast_guard doesn't get an icon in some maps, but the police one does, I'd suggest having a read of this: osm.wiki/Tagging_for_the_renderer b) The port's landuse tag value was changed from landuse=industrial back to landuse=harbour. You basically reverted to the 1st version that you created it. I had changed the tag to landuse=industrial because that's the recommendation on the wiki page of the tag (landuse=harbour) "Consider using rather landuse=industrial with industrial=port providing the same information in a structured way.". I have also checked how ports are tagged in other locations, and most of them use the suggested tag combination with landuse=industrial. c) For this one, I'm less sure, but should the road inside the port be classified as secondary highway instead of just be a service road? What’s the reasoning for this change? I look forward to your comments, fellow Corfu mapper :) |
| 147373697 | almost 2 years ago | Generally the tags should follow snake-case not camel-case, so it should be ref:kep_id. Because this id is something country specific and to not conflict with something else used internationally, I suggested to namespace it with the country code using ref:GR. Some other suggestion is that the building tag is mainly used in ways and not in nodes. If you see the building tag stats (https://taginfo.openstreetmap.org/keys/building#overview), there are 592 million ways with the building tag and only 1 million in nodes. Also the tag description in the wiki (building=government) mentions "Values of the building=* key should reflect the construction of the building, not its function". So it would be better to tag with office=government and remove the building tag (unless your tag a closed way, in that case it should be building=office). Another thing that can be improved is that the name should not be all caps. There is an error showing up in Osmose for it ex. https://osmose.openstreetmap.fr/en/issue/d8017990-4dc5-d179-a12c-c32df15b2a88 (Name with uppercase. Concerns tag: `name=ΚΕΠ ΛΕΥΚΙΜΜΑΙΩΝ`). So I think it should be ex. "ΚΕΠ Λευκιμμαίων". |
| 147373697 | almost 2 years ago | Thanks for the quick reply. Looking forward to the corrections. About the ref tag and generally about what other tags should be used to map this, I'm going to open a thread in the OSM community forum to check what the other people opinions are related to this. In the mean time, I'm going to combine the duplicate node that I mentioned earlier with the existing one. |
| 147373697 | almost 2 years ago | Hi Pantelis, First of all, thanks a lot for this contribution. An issue caused by this changeset is that it created duplicate nodes in some cases, such as the KEP for Lefkimmi (an area that I monitor). I guess that there are more duplicates like this. The duplicate entry was placed close enough but in a wrong building. Also the tags with the existing one are pretty similar: Existing: description=Κέντρο Εξυπηρέτησης Πολιτών (ΚΕΠ) Λευκίμμης
Duplicate: addr:country=EL
I think the process that created the edits should have tried to detect for existing nodes and to not create duplicate nodes but just edit the existing nodes. Also I have a question about the kepId. Would it be better to use the ref key for it (ref=*)? How about something like "ref:GR:kep_id"? Was this import discussed in any forum of the Greek OSM community? |