Jonathan Delaney's Comments
| Changeset | When | Comment |
|---|---|---|
| 188328369 | Hi, I saw you requested a review for this edit. For the most part its a good addition, but you didn't connect the roads together. When connected the intersections between roads should be gray. Also, don't abbreviate names (we leave abbreviations to the data consumers). Otherwise, everything looks good. I've fixed these issues at: changeset/188339024 Thank you for the contribution!
|
|
| 183622731 | Hi! Are you sure that these areas are still referred to by these names? I've never heard of them, and the Tumblr post you've linked says that Bethlehem was called South Mt. Auburn by 1910. The link for Jerusalem is dead, but it seems to be a similar early 19th century village. If they don't exist anymore, it would be more appropriate to add them to OpenHistoricalMap. |
|
| 187964147 | Hi! I saw you’ve been doing some more editing in this area and I wanted to check back in. I have noticed a few issues, which I’ve summarized below. I apologize that it's a wall of text, if you have any questions, please let me know. Once again, your contributions are appreciated, and although I’m covering a lot of stuff in one go the reality is that the area you’ve mapped is better off even with some mistakes. * ”name=*” is used for the primary name of a feature only. It isn’t used for descriptions, and most features don’t have any name at all. Names should generally also be written unabbreviated and written in Title Case. You can read more on the wiki here: name=* * “landuse=” describes what people use a land area for, not necessarily what the land looks like. With that in mind, wild forests should actually be tagged natural=wood. They are areas not currently used by people, so they do not get a landuse. Landuse=forest is used for cultivated areas of forest, where lumber is a crop. * Other landuses to double check are “farmyard”, “meadow”, and “farmland”. Farmyards are specifically part of a farm, and even though they may include a house where the farmer lives, areas with a house and outbuildings are usually not farmyards. Meadows, specifically “landuse=meadow; meadow=pasture”, is grazing land for cows. Farmland is commonly used for non-specific farming related land, but there are usually more specific tags that are better. If you’re not sure, tagging it farmland is fine, but consider if it's actually a meadow, farmyard, or something else. I recommend reading through the landuse=farmland wiki page and checking some of the other pages linked: landuse=farmland * Landuses should generally not overlap, and if there is no physical separation between two otherwise identical landuses they should be combined into one area. If there is one landuse completely inside of another, it should be a multipolygon: osm.wiki/Relation:multipolygon * Be careful with how you map areas. If two areas border each other, they should share a single line as the border. When making or editing an area, snap its border to the points on the borders of any adjacent areas. If there is a physical gap between two areas, you do not need to do this, but make sure to accurately follow the gap. * With buildings, the area should follow the footprint of the building on the ground, not how it appears in aerial imagery. Remember that the angle of the imagery can change between sources, so don’t include the peaks of roofs if they do not follow the base of the building. Also, it can be helpful to press “Q” to square buildings so that the angles are exactly 90 degrees. * When mapping a gate, show it in the closed position: barrier=gate * Remember to check for typos and confirm that your tags make sense. OSM is built to be read by computers, so even a single letter off will break things. If you’re using a new tag for the first time, check its wiki page to make sure you’re using it correctly. Generally, if the editor fills in a preset option go with that, and don’t ignore warnings if it gives you any. * I’m having trouble determining your sources from some of the data you’ve added. If you’ve seen it in person, please include “survey” as a source. Remember not to copy from Google Maps or proprietary sources. I’ve corrected the issues I spotted in changeset/188108924. I apologize if this is discouraging, it is not meant to be. Your contributions help to improve the map for everyone. Thanks again, if you have any questions, feel free to ask. |
|
| 187803432 | Hi, I saw you requested a review on this edit, and that you've made a few more in this area since. Overall, it looks good, but I've noticed a few issues. You've made the property surrounding Payneville Community Church a building. Landuse=religious would be appropriate here. I've also noticed a few parking lots that you've marked as highway=service; service=parking_aisle. This tagging is for the aisle between rows of parking in a large parking lot. A parking lot area should be tagged amenity=parking. Lastly, some of the farmland may be better tagged as something else (landuse=meadow for example), but farmland=* is sort of a catch all if you aren't sure. Otherwise I don't see any other major issues, and I'm glad to see this area getting some attention. Happy mapping!
|
|
| 187767893 | Hi, I saw you requested a review for this edit, and I've noticed a few issues. Please do not take this feedback personally, as it is common for new mappers to make mistakes. 1. name=* is used to define the name of the feature, and only the feature. It is unlikely that the driveway itself has a name. 2. It is also unlikely that the driveway has a max speed as it is private property. 3. parking:both:orientation=* is intended for designated parking alongside roads, and parking_space=* is for mapping individual spots in a parking lot. Generally, standard driveways wouldn't be marked with parking unless its specifically outlined on the road. 4. The driveway crosses over the sidewalk and does not intersect it. There should be a pop up in iD that let's you "connect the features" in one click. If you have any questions, feel free to ask. Happy mapping!
|
|
| 187531946 | I see what happened now, previously there was no data and "Show Address" was just guessing based on what streets were nearby. Now it doesn't have to guess. Hopefully this fixes your problem, but there's no guarantee that your GPS provider or delivery service use OSM data. If you still have issues, you may have to follow up with them directly. |
|
| 187531946 | Hi, I saw that you requested a review for this edit. I don't see any issues. I'm not sure where you are seeing a different address though, there aren't any Wychwood addresses on OSM. If you know them, it would be a great addition. Happy Mapping!
|
|
| 187550763 | Hi, I saw you requested a review for this change. Everything looks good, though you'll want to check it again once more up to date satellite imagery comes out.
|
|
| 187263098 | Thank you for your contribution! I noticed this road has the tag "name_1=South High Street". This communicates that the road has South High Street as an alternate name, and the primary name is South 400 W. If you believe that South High Street is the primary name (based on street signs, local knowledge, etc) it should be swapped to the "name=*" tag, but double check that the road isn't also technically a continuation of South 400 W. To complicate things, "name_1=*" is actually a deprecated tag. If you find that the road has an alternate name replace name_1 with "alt_name=*". Happy mapping!
|
|
| 187313199 | Edit reviewed, it looks good.
|
|
| 186464816 | Hi, I saw that you requested a review on this edit. It's a huge improvement over what was there previously, but there's a few things to look out for: 1. The parking lot node is redundant; the area is already tagged as amenity=parking.
Overall, though, it's a solid first edit. If you have any more specific questions, feel free to ask. |
|
| 165404113 | Weird stuff happens. Thanks for fixing it! |
|
| 165404113 | I'm not seeing the Spring Grove bike lanes mapped separately. It appears to have been tagged correctly before. Am I misunderstanding something? |