Hi,

Thanks for your reply. I had a quick look at the tram route in question and saw that the route relation had ways not ordered properly as well as some ways missing. I've fixed those issues in this changeset: changeset/162954477 , but I'm unsure whether the routing application you mention uses those relations or not, so it might not fix this specific issue. Nonetheless, it's good practice to make sure the route relations are done properly as it can cause routing issues on routers relying on them.

Hopefully you can find a solution to the problem. You haven't broken anything from what I can tell barring some minor issues with the route relations.

Hi Geo_Gunzel

I can see that you have made 13 changesets here attempting to fix a "routing error". I'm curious what the issue is and I'd be happy to have a look at it and help if needed! I just don't see what the problem is after glancing at your changesets, and am unsure why you're deleting a bunch of nodes to fix it. It might make the issue worse if you delete too many nodes, especially if deleting nodes didn't fix it the first few times.

Appreciate the work you're doing on public transit here.

Happy mapping!

Hi,

Thanks for contributing to OpenStreetMap :)

Just letting you know that there were quite a few duplicated segments of roundabout in this (and potentially other) chanegset(s). Might be a bug in relatify?

I have (hopefully) fixed those issues.

Might be worth checking to see if you have accidentally duplicated segments of roundabouts in other changesets!

Fixed in: changeset/160050163 changeset/160050057 changeset/160049989 changeset/160049960

Anyways, have fun mapping!

~Allie

Hi Liden,

Welcome to OpenStreetMap!

You've added a bunch of building nodes to the SRL East. They do not need to be connected as the railway will be underground.

Could you please remove these nodes from the railway:

node/12314247407
node/12314247408
node/12314247413
node/12314217108
node/12314217107

*and any others I may have missed*

Thanks for mapping, have fun :)

Hi,

Welcome to OpenStreetMap.

I can see that you have edited the SRL East in this changeset.

You added these house nodes to it: 12236606341, 12236581442, 12236606400, 12236606376, 12236606374, 12236581497.

node/12236581442
node/12236606341
node/12236606400
node/12236606376
node/12236606374
node/12236581497

The railway does not need to be connected to the houses as it will be underground. Could you remove those nodes from the railway please?

I'm pretty sure they are using this one

geojson: https://tasks.smartcitiestransport.com/api/v2/projects/71/tasks/?as_file=true

from

https://tasks.smartcitiestransport.com/projects/71#description

I just checked and the buildings are cutoff exactly along the borders of "taskId=172"

Hi,

Thank you for contributing to Open Street Map.

I can see you added the name "Residential Dwelling" to the houses in this changeset. That's not necessary to do as the houses are almost certainly not all called / are known by "Residential Dwelling". Please see the wiki page about names I've linked below.

name=*

If you could remove those names that would be great!

Happy mapping!

Hi Evie,

Thanks for your contributions to OpenStreetMap :)

Just letting you know that `amenity=parking_space` is typically used to map a single parking spot rather than the entire parking lot / area. `amenity=parking` is probably more what you're after for the parking you've added!

I've changed these areas to be `amenity=parking` rather than `amenity=parking_space`

way/1328693612
way/1328693610

Here's the wiki entries for those tags if you would like more information about mapping parking.

amenity=parking
amenity=parking%20space

Also, the description tag is usually more for describing something potentially useful for someone using the map rather than describing what you've added or changed. You don't need to add "added a parking lot" to the description of the parking lots, the changeset comment is probably the place you should write that.

description=*

Hope this information is helpful, and have fun mapping!

Hi, do you have a source for this name change? The website listed states the station's name as "Victor Harbour"

https://www.steamrangerheritagerailway.org/contact-us/

Hi Supt_of_Printing,

Just letting you know that a lot of bus route relations were broken by this changeset. I've since fixed them and split up ways to allow for appropriate routing of buses. In future please make sure to validate the bus routes after changing the the geometry of the roads.

There were also some issues with one ways connecting to one ways in the wrong direction as well as some general routing issues, but I'm not sure if it was because of this changeset or one of the other 5 with the same changeset description. Those issues should also be fixed now.

My Changesets: #157778281, #157778504, #157778599, #157778652

Also, it would be helpful if your changeset descriptions were unique and described what you were editing, as "edit Sunshine features" is not very descriptive and doesn't convey anything more than a no-comment changeset would. I can see the changeset location - Sunshine - and I can see that you are editing features. osm.wiki/Good_changeset_comments

I've fixed the relation order as well as remove the "forward" roles.

changeset/156041420

Does ID add "forward" roles to added ways on ptv2 routes, or did you manually add them?

Hi benniu, thank you for contributing to OpenStreetMap.

I've noticed that your changesets recently do not have clear comments that describe what you are doing with your edits. Most of them mention "test", but you don't clarify what you are doing to the map or what this "test" is. From what I can gather this a project for uni?

It's good practice to document your changes with a good changeset comment so that other mappers can understand what you are doing or at the least what you are attempting to do.

osm.wiki/Good_changeset_comments

The other reason I am commenting is that you may have used the wrong classification for the roads. You have changed a few service roads to primary_link. I invite you to read the wiki (highway=primary%20link) page for this tag, as I don't think it's use is appropriate here. Please let me know if I am wrong.

Hi ChonkerStonker,

Just letting you know that the 625, 626 bus routes were not ordered properly and some routes had members on both directions of road at roundabouts. This time, however, instead of a few ways being slotted at the end, about half the relation was in the wrong order. (Made it much less trivial to fix!) Do you download the entire relation while editing in iD? I'm wondering if it just add things at the end if its only got part of it. It did seem that you're attempting to order it though, so thank you :)

Anyways, fixed in changeset/155310065 changeset/155310265

Hi Esc,

From what I can tell this is good apart from a minor issue with the route masters (osm.wiki/Relation:route_master) of the train lines. The new platform you added (way/1299295128) was added to the superrelations, but those relations are meant to have all the variations of the train route not the actual route or platforms itself. The platform is just meant to be on the route relations which you added it to properly, (although in the wrong order!).

A quick way to check what type of relation is being edited is to look at the "type" key. type=*

type=route is the train route
type=route_master is all the possible train routes

I fixed it here: changeset/154887482

Hope that helps! Have fun mapping :)

Hi,

Thanks for contributing to OpenStreetMap.

In this changeset, you deleted this bit of road (way/1126557590/history). Is there actually not a road here, or was this by accident? Currently there are gaps in these bus route relations due to this changeset:

relation/10736859#map=19/-37.77134/144.96213
relation/5758780#map=18/-37.77134/144.96190

If it was done in error then this changeset would need to be partially reverted (and I don't know how to do that)

Hi ChonkerStonker,

This changeset added also caused issues with bus route relations. The newly made ways were added at the end of the route relations and you didn't sanitise for which direction the bus is meant to go in, so each bus route was going in either direction of the road for each roundabout.

Also, Highview Road (28640412) (way/28640412/history) should have been split in two from where it meet with Chesterville Road to properly allow for routes to turn left without going on the wrong side of the road. You can see what I mean here (way/1305487927) with what I did.

I've since fixed the routing in changeset/154794621 as well as splitting the road to allow for turning.

You should be able to see both bus routes following their respective correct paths here:
relation/2747625#map=18/-37.93026/145.06435
relation/11189472#map=18/-37.93026/145.06435

I know that this changeset was made before my first comments, but I've fixed at least 2 separate routes today that had issues caused by your edits. This changeset: changeset/153021217 being another one that had issues with the routes, fixed here: changeset/154794427. Just want you to be aware.

Please don't hesitate to reach out for assistance when it comes to routes!

Hi ChonkerStonker,

A bit nick-picky here, but, in this changeset you added the newly created Burlington Street ways to relation/8981021/history/81 at the end instead of in order. This makes it look like the bus "teleports" to the way after completing its route if you follow it in order. You also left the original ways from the other side of the road which that route doesn't go on, unless the bus actually travels on the right side of the road for roundabouts. I'm not sure if iD shows any warnings for this, but they appear as "Gap in route" errors on JOSMe and a few other tools. There were similar issues with relation/8981020/history/98 as well as some of your other changesets editing relations.

I've since fixed those routes in changeset/154758391 by removing the ways from the wrong side of the road and by reordering the ways placed at the end of the relation.

When editing bus route relations, please confirm that the bus routes are on the correct side of the road and are in order :)

Hopefully pointing this out to you is helpful and you know what to look out for now, but if what I said doesn't make much sense please let me know and I'll try and explain it better!

Thanks for all your contributions and have fun mapping!

Hi ChonkerStonker,

Just letting you know that both bus route relations you edited in this changeset had members on Ayr Street in the wrong order (wrongly put at the end of the relation) as well as a few gaps. I've since fixed those issues in changeset/154714567 and changeset/154714525.

No worries!

Hi,

Thank you for contributing to Open Street Map. Just commenting to let you know that I've changed the carpark way/909282332 roughly back to what it was. This is because the Bing Imagery for it is very out of date and doesn't accurately reflect what it looks like at the moment. The Esri World Imagery seems to be much more recent, especially when you zoom out with it. What I normally do is switch between the two imageries to make sure that nothing major has changed between them. Hope that helps!

Happy mapping!