Changeset: 147373697
Κέντρα Εξυπηρέτησης Πολιτών (ΚΕΠ)
Closed by pantelis001
Tags
created_by | JOSM/1.5 (18969 en) |
---|---|
source | GRNET Email : info@grnet.gr |
Discussion
-
Comment from alefteris
Hi Pantelis,
First of all, thanks a lot for this contribution.
An issue caused by this changeset is that it created duplicate nodes in some cases, such as the KEP for Lefkimmi (an area that I monitor). I guess that there are more duplicates like this.
The duplicate entry was placed close enough but in a wrong building. Also the tags with the existing one are pretty similar:
Existing:
description=Κέντρο Εξυπηρέτησης Πολιτών (ΚΕΠ) Λευκίμμης
email=d.lefkimmaion@kep.gov.gr
fax=+302662029019
government=yes
name=Κ.Ε.Π. Λευκίμμης
office=government
phone=+302662360230
website=https://www.kep.gov.gr/Duplicate:
addr:country=EL
addr:housenumber=222Β
addr:postcode=49080
addr:street=21ης ΜΑΡΤΙΟΥ
building=government
contact:email=d.lefkimmaion@kep.gov.gr
contact:phone=+30 2662360230
contact:website=https://www.kep.gov.gr/
kepId=0427
name:el=ΚΕΠ ΛΕΥΚΙΜΜΑΙΩΝ
name=ΚΕΠ ΛΕΥΚΙΜΜΑΙΩΝI think the process that created the edits should have tried to detect for existing nodes and to not create duplicate nodes but just edit the existing nodes.
Also I have a question about the kepId. Would it be better to use the ref key for it (https://wiki.openstreetmap.org/wiki/Key:ref)? How about something like "ref:GR:kep_id"?
Was this import discussed in any forum of the Greek OSM community?
-
Comment from pantelis001
Thanks for your comment Thanos.
We will make corrections in the uploaded dataset in the near future.For the tags we used the official information provided in https://www.kep.gov.gr/. We will consider your comment on the kepId tag.
-
Comment from alefteris
Thanks for the quick reply. Looking forward to the corrections.
About the ref tag and generally about what other tags should be used to map this, I'm going to open a thread in the OSM community forum to check what the other people opinions are related to this.
In the mean time, I'm going to combine the duplicate node that I mentioned earlier with the existing one.
-
Comment from pantelis001
OK, and I added ref: in the kepId tag.
The information provided in the tags comes from official sources and the projects carried in GRNET.
-
Comment from alefteris
Generally the tags should follow snake-case not camel-case, so it should be ref:kep_id. Because this id is something country specific and to not conflict with something else used internationally, I suggested to namespace it with the country code using ref:GR.
Some other suggestion is that the building tag is mainly used in ways and not in nodes. If you see the building tag stats (https://taginfo.openstreetmap.org/keys/building#overview), there are 592 million ways with the building tag and only 1 million in nodes. Also the tag description in the wiki (https://wiki.openstreetmap.org/wiki/Tag:building%3Dgovernment) mentions "Values of the building=* key should reflect the construction of the building, not its function". So it would be better to tag with office=government and remove the building tag (unless your tag a closed way, in that case it should be building=office).
Another thing that can be improved is that the name should not be all caps. There is an error showing up in Osmose for it ex. https://osmose.openstreetmap.fr/en/issue/d8017990-4dc5-d179-a12c-c32df15b2a88 (Name with uppercase. Concerns tag: `name=ΚΕΠ ΛΕΥΚΙΜΜΑΙΩΝ`). So I think it should be ex. "ΚΕΠ Λευκιμμαίων".
-
Comment from jimkats
Καλησπέρα,
Από την στιγμή που ήταν μαζική εισαγωγή δεδομένων, οπότε import, έπρεπε πρώτα να γίνει ενημέρωση της κοινότητας. Για αρχή διαβάστε τις οδηγίες στο wiki: https://wiki.openstreetmap.org/wiki/Import/Guidelines
Δεύτερον, δεν υπάρχει καμία αναφορά στην εισαγωγή αυτή για το ποιά είναι η ακριβής πηγή του dataset και ποιά η άδεια χρήσης. Το grnet σκέτο δεν δίνει την απάντηση, από την στιγμή που στο site τους δεν υπάρχει φανερά κάποιο link που να οδηγεί σε τέτοιο dataset.
Ανοίχθηκε συζήτηση στο φόρουμ, από όπου ενημερώθηκα γι' αυτό το import. https://community.openstreetmap.org/t/topic/109290
Πρέπει να συζητηθεί οπωσδήποτε το θέμα πριν προβείτε σε περαιτέρω edits όσων εισάγατε, κατά προτίμηση στο φόρουμ.
-
Comment from pantelis001
Το dataset προέρχεται από σχετικό έργο που έχει αναλάβει η εταιρία. Δημοσιεύτηκε στο πλαίσιο υποστήριξης των ανοικτών δεδομένων.
Welcome to OpenStreetMap!
OpenStreetMap is a map of the world, created by people like you and free to use under an open license.
Hosting is supported by Fastly, OSMF corporate members, and other partners.
https://openstreetmap.org/copyright | https://openstreetmap.org |
Copyright OpenStreetMap and contributors, under an open license |