Long story short: added VE woodland but removed it and all HD due to duplicate nodes. Took me a while to do that but learned about changesets, conflicts, validation etc.
Wrote vbscript to generate .bat file to run shp2osm jar file and generated all OSMs for 021G10. Used Sam's rules files (mostly unmodified).
Looked at the OSM attributes. Some comments to myself on whether translations are good, what's worth bringing in etc:
2010009_0 (spot height) is translated as man_made=survey_point; ele=*. I disagree with that. It is not man-made. It gets rendered with an icon showing a surveyor like a survey control point might be. Will not import. OSM does not seem very good for Z.
1460009 is rapids, good. But OSM map features does not have an approved tag it seems. ACT has proposed but it is "abandoned". Will import anyway.
1350012 is a pit, "an excavation from which gravel, sand or clay are removed." Translated as landuse:industrial. I disagree with the translation. It is not an industrial area in the sense of factories or industrial estate. Better translation would be landuse:quarry and resource=aggregate. Not sure if I will import. Could have topo significance?
1360019 is a "domestic waste" i.e. a dump. Translated as landuse:landfill. I agree.
2110009 is a lumberyard. Translated as landuse:industrial, type=lumber_yard. I disagree. type is a property and properties should describe the nature of some entity (e.g. it is "narrow" or "disused"). I think there should be a proposed feature landuse:lumberyard.
1210009 is NTS map sheet boundary. Translates as boundary:administrative which I think is wrong. There is no place for this in the OSM catalogue.
1000039 has 1000032 cemetery. Translates as landuse:cemetery. Good.
2270009 has 2270012 = Park/Sports Field. No entry for this in the Google spreadsheet. Gets translated as sport:multi. I think it should be landuse:recreation_ground. I don't think we can qualify it more than that. No point in saying anything about sport as we don't know what sports are practiced there and recreation grounds are "sporty" by definition.
2420009 is trail. Translates as highway:path, foot:yes, sac_scale:hiking. I think not many people are walking these trails in NB. ATV and snowmobile or maybe pickup truck. Anyhow, that's their encoding in Canvec and the translation seems right. Quite a few of these so worth importing.
2490009 is a picnic site. Translates as tourism:picnic_site.
1580009 is toponymy. Sub-classed as island, channel, unincorporated area etc. Seems good. One qualm: we have name and name:fr. Should it not be name:en and name:fr? Canvec has NAMEEN and NAMEFR. I think I will change the rules file for this. Maybe I'll read more about OSM and locales first...
1020009 is railway. Canvec for 021G10 tells us what railways there were in 1975. Oh well, we can always bring them in then recategorize a lot of them to trail or whatever.
1190009 is runway. Translates as landuse:airport and aeroway:aerodrome. Shouldn't it be aeroway:runway?
1760009 is road segment. ... Lots to look at here.
1770009 is junction. I don't think I should care. I notice a tag delete_me:yes. Good idea...
1780009 is blocked passage. Translates as barrier:bollard. Barrier is good but who knows whether it is a bollard, which would be more common in urban areas. It is highly unlikely to be a bollard. More likely a gate or a ditch cut across the road. And the tags for horse, bicycle etc? How does anyone know? Maybe some rule adjustment needed here.
May not have much more time for this in the next few weeks. We'll see....