philipcullen's Comments
| Changeset | When | Comment |
|---|---|---|
| 186453061 | Good idea - I'll add notes to any that are similar in future |
|
| 186454199 | My logic on this one was that it is the only UPRN linked to that USRN that is not unambiguously linked to a building, and falls on the centre line of a road with nothing else visible in the vicinity that is a likely candidate. In my experience most areas add these street records at junctions, but some areas (like this one) do add them somewhere along the road. |
|
| 186364703 | Will do. I'll try and make my chaneset descriptions more descriptive and split them out as you suggest. I also find it strange that having created USRNs, UPRNs are assigned to represent the same object, though UPRNs seem to almost have become a general purpose way of specifying coordinates in some cases, with things like ponds often having them. |
|
| 186364703 | Hello, I believe that UPRN is the street record. My basis for this was that it links to the same USRN for that street, is centred to the road, there isn't another candidate to be a street record, and there wasn't anything nearby (street furniture, postboxes, etc) that could be another candidate. I've found that the positing of street records varies by area (though is consistent within them). They always seem to be aligned at the centre point of the street, but can either be positioned exactly at junctions, offset from a junction to the be on just the street in question, or somewhere central on the street. I do agree that it only makes sense to add UPRNs to that confidently match things in OSM and that the list of "unmatched" is very valuable in itself. My thinking on adding street records, in the absence of any open data on the UPRN type, is that this reduces the list of unknowns to ones that genuinely need investigating. |
|
| 185436688 | You're right. Thanks for spotting that and fixing them. I really must write a JOSM validator to spot these. |
|
| 166003346 | Thanks for pointing this out - I'll review them over the next few weeks. |
|
| 184609079 | Good spot - that was a copy & paste error and should have been in addr:postcode. I've now fixed it. |
|
| 177078340 | Hello, I generally use cadastral parcels for "boundaries" between parts of buildings, and UPRNs as (typically) centres of buildings. I would generally only re-align buildings based on the cadastral parcels - so apologies if my comment wasn't clear about this. I do try and blend the alignment between cadastral-parcels and existing where I can, to avoid any discontinuities along the way. As you know, there is a balance to be stuck between accurate on an absolute vs relative scale, and I try to balance both - but not always perfectly. I always prefer to fix anything I've broken myself, if possible, so I'll look over this in the next few weeks. On that note, I appreciate you bringing it to my attention. (I feel that I should point out that I genuinely mean this, not based on your messages, but on general correspondence). It sounds like our our approaches are very much aligned, but might have queries about edge cases, I had previously tried to group related changesets into a larger changeset, but based on feedback, these might be better broken down to smaller geographic areas. I try and do this for any new changesets. As always, I'm happy to receive advice and recommendations on any changes. Phil |
|
| 177078340 | Hi, I generally try and align with Cadastral Parcels, and UPNRs (as a centre point to buildings). I tend to combine changesets with UPRNs and other addressing date with geometry, as I find they are so interlocked that working with both together makes things easier. I will have a look over the area to make sure the geometry changes make sense. I might not be able to do this immediately, but as you've asked, I'll put it at the top of my list. Phil |
|
| 179805865 | I had intended to split this the initial changeset, but had left the "auto close" setting in JOSM off in error, so they all ended up in one large one. I'd be more than happy to split them out, but my understanding is that it is not just the size of individual changsets, but their aggregate volume that concerns local mappers, so I wouldn't want to jump in and do that if it wasn't welcome. (I'd also need to work out how to do that, but that's a lesser problem) |
|
| 179469029 | Maybe a building:part or distinct entrance node might be appropriate, but as you say, it needs more information or ideally a survey. I just wanted to let you know. |
|
| 179468888 | Thanks - that is a very good spot! |
|
| 179469029 | Hello, I wonder if this might be part of the building carved out to be independent? A few sources online suggest that may be the case, but nothing usable for OSM. Anyway, I'll defer to your local knowledge, but just wanted to point this out. |
|
| 179469481 | Thanks, I think we were both changing it at the same time, which might be behind the confusion here. I generally don't add addresses to this sort of thing, but I've come across quite a lot of areas that do. I do think the postcode should be in postal_code rather than addr:postcode (if at all), as wouldn't really have a postcode as such. |
|
| 179419707 | No worries - we're all limited by tooling. That sounds like a sensible default for residential-but-ambiguous, so I'll go with "residential" rather than "house" for these instances. |
|
| 179419707 | Thank you - I'd not quite finished this changeset, but this is a good catch that I wouldn't have spotted (which is the best type of catch). I've added that multiple UPRNs on each side of a semi-detached house might indicate an issue to my checks, but not considered that building=residential might be more appropriate than building=house for these types of buildings. |
|
| 175847222 | Hello, I've added those UPRNs are they appear to be the UPRNs for the street record. These tend to be at the end of a road, but can sometimes be elsewhere along the length. I've tried to add them to the point in the road that they have been placed, as they tend to be helpfully well aligned with the centre of the road. There will be a USRN for the roads too, which would need to go on the way for the road, but I've not added these. |
|
| 177467958 | Ah yes, Isle of Wight not White, I must have done the changeset comments in a hurry. |
|
| 177533620 | I'm sure we're all working towards the same aims and in good faith - the recent edits were much smaller and I'd thought would be more inline with how you preferred them - there was no ulterior motive behind them. I do occasionally fix things I come across unrelated to what I've intended to do, perhaps they should be in a new changeset, but I've always seen them as inconsequential. I do see you point on that though. A third perspective will, I'm sure, be helpful. My offer to help you with targeted reverts, if needed, still stands. Phil |
|
| 177533620 | I don't believe a revert is the best course of action here. A significant number of the UPRNs are added completely manually (I have tooling to make this quicker, but it still requires selecting the object and UPRN), so they are not as easily replaceable as you suggest. I combined improving geometry and adding UPRNs as I find the processes benefit each other. I do believe that adding UPRNs is a benefit in, and of, itself, but I think the combined workflow benefits are much greater. I would like to suggest an alternative approach, and I hope you will reasonably consider it: I'll look through all the objects with UPRNs that are either not a building, or building=yes and check that they make sense. For building=yes, I'll upgrade to a more specific tag where appropriate. I'll continue doing this in smaller batches (geographically), as we've previously discussed. Whilst I'm doing this I'll improve geometries - I find this benefits from having the UPRN details added. A suspect this will make you less comfortable - but I believe this will alleviate the need you feel to manually revier every change. As a general approach, I believe that asking people to fix their own errors (where they are able) usually yields the best results for everyone. I would hope that this might also reduce the frustration that you feel - I never undertake anything wanting to negatively impact on other people. After, say a month, then we could look at the total combined impact. If you still feel that parts should be reverted, then I'll work with you to do that (I have some tooling that would help in this). I know this would be a leap of faith for you, but in the meantime, I'd ask you to avoid feeling the need to review all changes I make, or if you do, let me know what you'd like to be improved. Phil |