chachafish's Comments
| Changeset | When | Comment |
|---|---|---|
| 74553359 | over 6 years ago | Hello, thank you for your additions to the map. Could you make future changesets smaller so it's easier to see what is being changed? Thanks :) |
| 74577121 | over 6 years ago | Hello, thank you for your additions to the map. Could you make future changesets smaller so it's easier to see what is being changed? This changeset extends from Las Vegas to Boston. Thanks :) |
| 74549901 | over 6 years ago | Also, I think you want a steeper angle on your skillion? I don't know what the default angle is for f4map, but you can take the guess work out of the equation by entering a value. Just enter, roof_height=* This value tells the renderer how much of the building part should be dedicated to the roof shape. For example, a value of 1 would make a skillion slant almost unnoticeable. A value of 3 or 4 would make the slant deeper than it's currently displaying. Do you know the actual height of the Industry building? If you could find it and enter it into the building tag, it would make rooftop element mapping much easier :) |
| 74549901 | over 6 years ago | A skillion roof needs a few modifiers to make it look right. When I work with this roof type, I have to imagine I'm a raindrop hurtling down towards the skillion roof. When I hit the roof, which direction will I flow down the roof? Based on a 360-degree circle, the direction I flow down the roof is the value that has to be placed in the tag. As it is, this renderer has the skillion angle facing the wrong way - I think. https://demo.f4map.com/#lat=39.7709709&lon=-104.9708090&zoom=20&camera.theta=72.044&camera.phi=35.753 |
| 74549901 | over 6 years ago | Howdy! I guess you knew I'd be watching :) This is some nice 3D work. The choice of skillion surprised me. Skillion is one of those oddball roof shapes. I can't find any actual images of the roof here. Do you have any you'd care to upload to Mapillary? ;) I could only find the link below. Is this model Concept3D work? https://rinoartdistrict.org/go/industry-rino-station |
| 72021289 | over 6 years ago | I use OSM Inspector, https://tools.geofabrik.de/osmi/
|
| 72021289 | over 6 years ago | Hello, thank you for your additions to the map. In this changeset you added a proposed element. This is popping up as an error on QA tools. Just so you know, the correct way to tag proposed elements is; "The way to tag planned features is to use the main tag (Key, e.g. highway, railway, amenity, aeroway, ...) and add proposed as value. Then you create another tag proposed=* with x being the <value you usually would put on the main tag>." You can find this information in the link below. Thanks :) proposed=*?uselang=en-US |
| 74412634 | over 6 years ago | Very nice 3D work here on a difficult project. Not an easy task at all ;) |
| 74412375 | over 6 years ago | Your 3D work here is excellent. All the tags look great - except the two areas weren't tagged with building:part=yes. Other than that, it's all great. I updated the tags so you can see how they should look ;) |
| 74412672 | over 6 years ago | Excellent 3D work here. The portico looks great :) |
| 74411957 | over 6 years ago | Very nice 3D work here :) The only issue is that the building has a "colour" assigned on the north wing, but still lacks tags on the center area and the southern wing. You can view it on F4map: https://demo.f4map.com/#lat=39.8156839&lon=-105.0829097&zoom=20&camera.theta=61.272&camera.phi=116.597 |
| 74412978 | over 6 years ago | Good 3D edits here. Instead of building:part=roof, we need to use building:part=yes. We can add additional roof tags to the building:part=yes area afterward. All your work is well done and tight. I've changed just a few small things. Good job :) |
| 74412184 | over 6 years ago | I changed a few of the 3D tags here so you can see how they should be done. Thanks :) |
| 74473374 | over 6 years ago | I changed a few of the 3D tags here so you can see how they should be done. Thanks :) |
| 74412571 | over 6 years ago | Very good 3D work here. It's almost perfect. The awning on the north side of the building is awesome. Just a couple of things. Here, you can see you missed just one node when you created a building part: osm.org/edit#map=23/38.83484/-104.79528
|
| 74412069 | over 6 years ago | Excellent 3D work here. You're the first of the group to get a perfect score :) This building is not displaying on F4map correctly yet, but it looks super here: https://osmbuildings.org/?lat=38.83370&lon=-104.80952&zoom=20.0&tilt=45&rotation=336 |
| 74412185 | over 6 years ago | Very nice 3D work here. I like how well you cleaned up the multiple building issue. Just some small things, "colour" should either be "building:colour" or "roof:colour". "colour" would not be a stand-alone tag. I'll clean up those tags for you so you can see what it should look like. Thanks :) |
| 74412710 | over 6 years ago | Very nice 3D work here. There are only three things that need to done and it'll be perfect. The building needs to be tagged as retail. Also, the two southern-most building parts have four connecting nodes. They should have five connecting nodes. When you drew the area you overlooked one connecting node point. Does that make sense? Thanks :) |
| 74412267 | over 6 years ago | Correction to my last, "We need to add height=13.2 to the body of the building and to the pertinent building part." I'll also add roof shape to the 14 meter sections so you can see that. |
| 74412267 | over 6 years ago | Nice 3D work here. If you look at it on F4map, you'll notice the a/c units don't display. The reason is their height (0.5), is good, but as it is, 0.5 is the height from the ground. So, they are there, but they're buried in the body of the building. The roof is 4-stories up in the air, or about 13.2 m. We need to add height=13.2. Then we need to add min_height 13.2 and height 13.7 to the a/c units. I'll make the edits so you can see. |