Changeset: 73137843
Upload addresses for Killara
Closed by daviewales
Tags
created_by | JOSM/1.5 (15238 en_AU) |
---|---|
source | source:import=NSW LPI Web Services |
source:import | NSW LPI Web Services |
Discussion
-
Comment from Warin61
number of these addresses do not match the road names in OSM as they have the suffix "East" added. The DCS base map also does not show these "East" suffixes ...
Comment?
-
Comment from nevw
Hi, I can fix these if you like.
-
Comment from nevw
I have gone ahead and corrected these
https://www.openstreetmap.org/changeset/141794983
https://overpass-api.de/achavi/?changeset=141794983 -
Comment from Warin61
I too can 'fix' them. However there are a number address issues. I'm thinking about some resolution. I have raised one issue on the tagging list and I think a solution would also suit some of these address issues too.
-
Comment from nevw
Yes, there is a need for new addr or postal tagging for community groups like gated communities but I expect this changeset was some sort of cut and paste error.
-
Comment from Warin61
It could be an error on the LPI/DCS data base ...
Mowbray Road West for example in OSM is Mowbray Road I have added the Mowbray Road West as an alternative and changed the relevant addresses in OSM to match and used addr_postal:street for the Mowbray Road West ... -
Comment from daviewales
Good catch! This was from this import project:
https://wiki.openstreetmap.org/wiki/Import/Catalogue/Australia_NSW_Property_and_Address_Import
Most information and the full history of uploaded and reviewed address files is in the GitLab repository:
https://gitlab.com/dionmoult/osm-nsw-address-import
My best guess as to what happened here is that the script fetched points within a bounding box which included the suburb. It was then supposed to remove points which were not from the suburb in question. In this case, it would have removed points which are not from Killara. However, I'm guessing there was (or is) a bug which prevented it from removing points from East Killara. (These should have been removed and added in a separate changeset).
The second issue is that the LPI property API returns the address as a single field '10 Example Street Suburb'. To split this into the format required for OSM, the script removes the right-hand side of the address matching the suburb we are supposed to be uploading. In this case, it removes 'Killara' from the right-hand side of the address. However, because it failed to exclude the 'East Killara' addresses earlier, it just removes 'Killara' from the end, and leaves '10 Example Street East' as the address.
Sorry for not catching this in review.
-
Comment from Warin61
"There is always one more bug"
The good thing is that with the greater amount of data that cross references to other data there is more chance that any bugs will be found and sorted.
Ways (6)
Welcome to OpenStreetMap!
OpenStreetMap is a map of the world, created by people like you and free to use under an open license.
Hosting is supported by Fastly, OSMF corporate members, and other partners.
https://openstreetmap.org/copyright | https://openstreetmap.org |
Copyright OpenStreetMap and contributors, under an open license |