I think traffic_signals=pedestrian_crossing is only for signalised pedestrian crossings - "A traffic light that only turns red to let pedestrians cross" (first link) - , not for pedestrian crossings at junctions, and I think it is ok to have traffic_signals=signals where the stop buttons are
"You can use highway=traffic_signals for pedestrian crossings to indicate the signals, that is, where to stop or where the button is located." (second link)

Yeah for sure

Ah my mistake! I didn't realise there was a tag for that and I don't think it had it since it was reported as having no entrance, I'll re-add it with the correct tag

Unless I'm misunderstanding should they not be unmarked because they're on-street