Changeset: 71456361
Fix broken polygons
Closed by sebastic
Tags
created_by | JOSM/1.5 (15155 Debian en) |
---|---|
source | Bing |
Discussion
-
Comment from SomeoneElse
Ye Gods! 3801 relation changes!
How on earth did you manage to check each one? What did you change in each case?
Best Regards,
Andy -
Comment from sebastic
JOSM Validator is your friend. It started with fixing broken polygons (inner way outside mostly), then on initial upload there were several easy to fix validator issues. Just removing the deprecated is_in tags doesn't need to be checked for every object.
-
Comment from SomeoneElse
Using JOSM Validator on a large swathe of objects without any checking by you counts as an automated edit and should follow the automated edits code of conduct set out at https://wiki.openstreetmap.org/wiki/Automated_Edits_code_of_conduct .
Don't do it, or you'll be prevented from editing OpenStreetMap.
I have regularly seen things that JOSM validator suggested ought to be fixed but in reality were perfectly OK (and to be fair to the JOSM developers they usually fix such issues really quickly when pointed out to them).
Also, changing things so that they are "logically correct" doesn't guarantee that what results actually matches the physical reality. An example of this may be https://www.openstreetmap.org/changeset/71425070 - It looks to me like the "bare_rock" tag ought to apply to the whole area.
Also, for the avoidance of doubt, removing "is_in" adds no value to OSM; it just creates another version of everything.
Back to the original questions "How on earth did you manage to check each one?" and "What did you change in each case?", can you please go through all your changes here and check them, and say what you have changed and why?
I'd start by extracting "before" and "after" relations from your changeset and working out which ones were only an "is_in" change, and then looking at the others to see what happened. That will reduce the relations that you need to look at from 3081 to a more manageable number.
You've mentioned the "inner way outside" ones - those obviously do all need to be checked manually to ensure that you weren't "fixing" essentially "garbage" data.
Best Regards,
Andy Townsend, on behalf of OSM's Data Working Group. -
Comment from sebastic
You can't make volunteers do work. If you want to ensure that I didn't break anything, that's on you.
Block my account if you want to prevent me from breaking anything in the future. You'll need to find someone else to do this QA work and maintain the administrative boundaries in The Netherlands.
Ways (1-20 of 22)
- 1
- 2
- Illa de Cortegada (4889752), v12
- Isla del Rey (8692583), v24
- Isla de Isabel II (8692613), v24
- Peñón de Alhucemas (8692684), v20
- Isla de Tierra (8692720), v18
- Isla de Mar (8692779), v15
- Isla del Congreso (8692812), v25
- Illa Malante (18793204), v13
- Sisarga Chica (18793205), v9
- 45369970, v5
- España (mare territorial) (236586972), v12
- 381973438, v13
- 437424202, v4
- 625770211, v2
- Illa de Tambo (645314937), v5
- Illa de Sálvora (652384270), v3
- Illa de Sálvora (652384271), v2
- Illa de Sálvora (652384272), v5
- 656211284, v4
- 660595122, v2
- Cenicero (345228), v6
- Almendral de la Cañada (345233), v5
- Karrantza Harana / Valle de Carranza (345237), v12
- Bargas (345240), v7
- Barcience (345241), v5
- Láncara (345249), v5
- Las Casas del Conde (345250), v6
- Casillas de Flores (345251), v8
- Castellanos de Moriscos (345252), v6
- Lourenzá (345253), v6
- Castillejo de Martín Viejo (345254), v6
- Castraz (345255), v6
- Cepeda (345256), v8
- Cereceda de la Sierra (345257), v7
- Altable (345263), v5
- Lugo (345264), v10
- Meira (345266), v5
- Autillo de Campos (345270), v5
- Autilla del Pino (345271), v5
- Amusco (345275), v5
- Cabezas del Pozo (349238946), v9
- Cisla (349238948), v7
- Mamblas (349238949), v7
- Langa (349238951), v6
- Fuente el Saúz (349238957), v8
- Bernuy-Zapardiel (349238959), v8
- Fuentes de Año (349238961), v9
- Barromán (349238962), v7
- Castellanos de Zapardiel (349238963), v7
- La Bouza (349235393), v7
- El Arco (349235399), v8
- Rágama (349235420), v8
- Paradinas de San Juan (349235422), v8
- Zorita de la Frontera (349235423), v8
- Villar de Gallimazo (349235429), v8
- Villoria (349235432), v10
- Cordovilla (349235434), v10
- Moríñigo (349235437), v9
- Villoruela (349235439), v8
- Palaciosrubios (349235442), v7
Welcome to OpenStreetMap!
OpenStreetMap is a map of the world, created by people like you and free to use under an open license.
Hosting is supported by Fastly, OSMF corporate members, and other partners.
https://openstreetmap.org/copyright | https://openstreetmap.org |
Copyright OpenStreetMap and contributors, under an open license |